[4.x] Various metrics test improvements to avoid intermittent failures #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
changed the title
tomas-langer
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Could you maybe change the retry matcher not to throw an interrupted exception, but to call fail(interruptedException) or throw a runtime exception?
I don't think we need to handle InterruptedException in any specific way, so it may be easier to have no checked exception at all (and in the end less code in our tests)
…just method sigs of call sites
|
Changed |
tomas-langer
previously approved these changes
Dec 7, 2022
…terruptedException any more
tomas-langer
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5345 (at least partially)
I reviewed all the metrics tests. I found some places to improve, but I did not identify specific causes for two of the failures Tomas described in the issue. They are certainly not simply "retry" problems.
I will continue looking into those, but I did not want to delay these improvements.